I can confirm this problem. Using the latest SVN checkout (on June 20th), attempting to call Highlight produces the following error (via Firebug):
this.__init__ is not a function MochiKit.js (line 5265) This is with the packed code. Is this enough info to reproduce the bug with? Topher Bob Ippolito wrote: > On Jun 18, 2006, at 3:56 PM, whit wrote: > > > Bob Ippolito wrote: > >> > >> On Jun 18, 2006, at 2:12 PM, whit wrote: > >> > >>> *From: *whit <[EMAIL PROTECTED] <mailto:[EMAIL PROTECTED]>> > >>> *Date: *June 18, 2006 1:35:41 PM PDT > >>> *Subject: **pulsate patch* > >>> > >>> > >>> poking around on trunk. patch fixes missing 'this'. > >>> > >>> -w > >>> Index: Visual.js > >>> =================================================================== > >>> --- Visual.js (revision 1027) > >>> +++ Visual.js (working copy) > >>> @@ -1630,7 +1630,7 @@ > >>> duration: 3.0, > >>> from: 0, > >>> afterFinishInternal: function (effect) { > >>> - d.setStyle(effect.element, {opacity: oldOpacity}); > >>> + d.setStyle(effect.element, {opacity: this.oldOpacity}); > >>> } > >>> }, options || {}); > >>> var oldOpacity = d.getInlineOpacity(element); > >> > >> That patch is incorrect, it doesn't fix anything. oldOpacity is in > >> the closure, not on "this" (and even if it was on "this", it would > >> still be wrong because it's in a different function). > >> > >> -b > > ugh...actually it just breaks more stuff. this explains why I got > > different errors after my edit. my bad for hastily misdiagnosing. > > > > I originally got this error on the packed version, and after > > changing the the variable oldOpacity in the closure to match the > > variable that is created for oldOpacity during packing, I get no > > errors and pulsation as expected (see patch). > > Hope this helps. > > Patches against the packed version are no good. If you want a patch > applied, we're going to need a patch for the source, not generated > code. I'm also especially hesitant to take a patch that fixes > "something" when we don't have an example that reproduces the > problem. How do we know if it actually resolves the issue? > > -bob --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "MochiKit" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/mochikit -~----------~----~----~----~------~----~------~--~---
