[mochikit] Re: Announcing MochiKit.Animator - an animation engine that doesn't suck

[Tom W.M.]

First, I'd like to thank you for converting this great library to MochiKit.  You have saved me a lot of trouble on a project that I'm working on.  I have several suggestions:

1. Get rid of the addEffect/addSubject dual API.  It's confusing.  Fumble around for two hours trying to figure out the difference, to be specific (in my defense, I was a bit sleepy).  I don't really think that maintaining direct API compatibility is necessary; you've already renamed the classes, and it's not like there is a huge user base to convert.
   
2. I would like some way to apply different transitions to different effects within the same animation.  You could add a setState method to Animation, then just apply the Animation's transition to the animatonState argument and _propagate() it, or create a new class for the task.
3. Some improved error handling.  In particular, if a subject neither has a setState method nor is a function, the animation will never terminate.  For me, Firefox crashed after about 20,000 exceptions.

Also, on line 182 in removeSubject, an Array method, "reject," is used to remove the subject.  Since this line is identical to the implementation in the original Animator, I guess this is something from Prototype.

--Tom


--~--~---------~--~----~------------~-------~--~----~
 You received this message because you are subscribed to the Google Groups "MochiKit" group.
To post to this group, send email to mochikit@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at http://groups.google.com/group/mochikit?hl=en
-~----------~----~----~----~------~----~------~--~---