On 11/11/06, Tom W.M. <[EMAIL PROTECTED]> wrote: > Get rid of the addEffect/addSubject dual API. It's confusing. Fumble > around for two hours trying to figure out the difference, to be specific (in > my defense, I was a bit sleepy). I don't really think that maintaining > direct API compatibility is necessary; you've already renamed the classes, > and it's not like there is a huge user base to convert.
I did think about this, but I do actually use it for a few things outside effects (e.g. kicking off a wave style animation as seen on the mootools main page), and I find addEffect a bit weird when I'm actually using it to animate a value. I have a mostly-complete API doc in the style of the rest of the MochiKit docs, which explicitly lists both as aliases. > I would like some way to apply different transitions to different effects > within the same animation. You could add a setState method to Animation, > then just apply the Animation's transition to the animatonState argument and > _propagate() it, or create a new class for the task. There's an undocumented transition attribute on each effect which will override the values coming from the animation. I plan on adding an extra 'options' parameter to the effects and cssAnimation so you can set this at instantiation. > Some improved error handling. In particular, if a subject neither has a > setState method nor is a function, the animation will never terminate. For > me, Firefox crashed after about 20,000 exceptions. I'll definitely add an error check there. > Also, on line 182 in > removeSubject, an Array method, "reject," is used to remove the subject. > Since this line is identical to the implementation in the original Animator, > I guess this is something from Prototype. It is. If you can't tell, this was the result of a major weekend hacking session and the demo page is my test page. Code branches not covered haven't been exercised (I wrote it for a project that is a subset of the tested functionality). Any error reports are appreciated. I plan on trying for a push to a 1.0 RC tomorrow evening with a 1.0 release some time later next week with API docs, a few more flashy demos, possibly 1.3.1 compatibility and a compressed build. --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "MochiKit" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/mochikit?hl=en -~----------~----~----~----~------~----~------~--~---
