Ok, it would be great if you looked at this! I did something similar once, but it is a bit of a pain to read 4 computed values (which is slow) instead of just using offsetHeight. But since it is just used during initialization, speed won't be a problem here. But we should still keep it separate from getElementDimensions for performance reasons I think.
Cheers, /Per On Wed, Jun 11, 2008 at 10:50 AM, Christoph Zwerschke <[EMAIL PROTECTED]> wrote: > > Per Cederberg schrieb: > > After investigating this, I think the main problem here was introduced > > in revision 1383. That change introduced the new functions > > MochiKit.Style.getElementHeight and MochiKit.Style.getElementWidth and > > changed MochiKit.Visual to use them in several places. There are > > apparently issues with these functions and they are also lacking test > > cases. > > Maybe we can solve this by calculating getElementHeight in a different > way, as jQuery does it, namely by using the existing getDimensions > values and then subtracting padding and border (see also > http://trac.mochikit.com/ticket/84). But I agree we also need more tests > for these functions. I will try to look at this again this weekend. > > -- Christoph > > > > --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "MochiKit" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/mochikit?hl=en -~----------~----~----~----~------~----~------~--~---
