I think I fixed the MochiKit.Selector issue with "div ~ p" in r1429 by adding a uniqueness filter on the results from MochiKit.Selector.findChildElements. Unless the number of returned results is very high it should not degrade performance much. And naturally, this should also fix the issue for "div p".
Arnar, could you add a new trunk MochiKit to your speed comparison page? Otherwise, I look forward to replacing the current implementation that is based on eval usage, poor query parsing and slow set handling. Not much fun to debug at all, actually... Cheers, /Per On Wed, Oct 15, 2008 at 10:21 AM, Arnar Birgisson <[EMAIL PROTECTED]> wrote: > Hi Per, > > On Wed, Oct 15, 2008 at 10:15, Per Cederberg <[EMAIL PROTECTED]> wrote: >> On Wed, Oct 8, 2008 at 9:28 PM, Arnar Birgisson <[EMAIL PROTECTED]> wrote: >>> div p >>> MK trunk returns 142 elements while others return 140 (both numbers >>> are reported incorrect though). The *set* of elements is the same, but >>> MK repeats some elements, which is of course not correct. This seems >>> to happen in the situation where one has >>> <div><div><p>...</p></div></div>. If one forgets about performance, >>> this is trivial to fix in MK - but a reasonably performing one might >>> be more tricky. >> >> I'll let this one pass. It is slightly incorrect, but can be >> worked-around by users until 1.5 comes along. > > I agree. > >>> div ~ p >>> MK returns 4120 (!) elements here where others return 183 (both >>> numbers are again considered wrong by SlickSpeed). This is clearly a >>> bug >> >> I'll try to fix this. Filed as http://trac.mochikit.com/ticket/321 > > Thanks, let me know if you have problems. I'm sorry I don't have time > to help more these days, I have a few deadlines and a conference > coming up in the next two weeks. > > cheers, > Arnar > --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "MochiKit" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/mochikit?hl=en -~----------~----~----~----~------~----~------~--~---
