Nice work Loïc,
One alternative approach would be to create a #define for
hildon_file_chooser_dialog_new in modest-hildon-includes.h, as
that is the approach we use there to support slightly different
APIs, so we don't need have to have #ifdefs in the rest of the code.
Ie, something like
#ifdef MODEST_HAVE_HILDON_FM
#define hildon_file_chooser_dialog_new(a,b) \
gtk_file_chooser_dialog_new(NULL,a,b)
#endif /*MODEST_HAVE_HILDON_FM*/
Anyway, I'll let Sergio the Great decide :)
Best wishes,
Dirk.
> -----Original Message-----
> From: [EMAIL PROTECTED]
> [mailto:[EMAIL PROTECTED] On Behalf Of
> ext Loïc Minier
> Sent: Thursday, August 28, 2008 16:38
> To: modest-devel@garage.maemo.org
> Subject: Re: [Modest-devel] [patch] building without hildon-fm
>
> On Thu, Aug 28, 2008, Loïc Minier wrote:
> > The API/ABI doesn't map one to one, and it would require
> at least one
> > or two weeks of solid development and testing to move to the new
> > models. The resulting code in hildon-fm would probably be
> a mess to
> > maintain too if it uses conditionals heavily -- and that
> would be for
> > Gtk+ 2.13 support which isn't in their current platform... :-/
>
> Just for the record, some of the API changes:
> GtkFilePath, GTK_TYPE_FILE_PATH, gtk_file_path_*
> => GFile, G_TYPE_FILE, g_file_*
> GtkFileSystemHandle
> => ~ GCancellable
> GtkFileInfoType
> => quite hard to map as it expresses GFileInfoType and
> GFileAttributeType infos at the same time
> GtkFileInfo
> => ~ closest to GFileInfo
> GtkFileFolder, gtk_file_folder_*
> => GtkFolder, gtk_folder_*
> gtk_file_system_path_is_local
> => didn't find an is_local test; it seems you have to test for
> nfs, smb etc. prefixes :-(
> gtk_file_paths_free, gtk_file_paths_copy, gtk_file_path_compare,
> gtk_file_paths_copy etc.
> => needs new implementations; Gtk+ doesn't provide gslists or
> comparison utilities like the previous ones
> etc. etc.
>
> --
> Loïc Minier
> _______________________________________________
> Modest-devel mailing list
> Modest-devel@garage.maemo.org
> https://garage.maemo.org/mailman/listinfo/modest-devel
>
_______________________________________________
Modest-devel mailing list
Modest-devel@garage.maemo.org
https://garage.maemo.org/mailman/listinfo/modest-devel
