On Mon, 21 Aug 2000, Lupe Christoph wrote:
> On Sunday, 2000-08-20 at 23:45:55 +0200, Stas Bekman wrote:
>
> > Lupe,
> > It seems to be broken. I cannot open the package.
>
> I've uploaded it again, and will be testing it myself.
>
> To be sure you get it, I'm attaching the tarball, it's minor, anyway.
Thanks, Lupe.
A few comments followed by the answer to your original question.
make install
Manifying blib/man3/Apache::Changes.3
Manifying blib/man3/Apache::Perfmon.3
Manifying blib/man3/Apache::README.3
Installing /usr/lib/perl5/site_perl/5.005/Apache/Perfmon.pm
Installing /usr/lib/perl5/site_perl/5.005/Apache/Changes.pod
Installing /usr/lib/perl5/site_perl/5.005/Apache/README.pod
Installing /usr/lib/perl5/man/man3/Apache::Changes.3
Installing /usr/lib/perl5/man/man3/Apache::Perfmon.3
Installing /usr/lib/perl5/man/man3/Apache::README.3
All these:
Installing /usr/lib/perl5/site_perl/5.005/Apache/Changes.pod
Installing /usr/lib/perl5/site_perl/5.005/Apache/README.pod
Installing /usr/lib/perl5/man/man3/Apache::Changes.3
Installing /usr/lib/perl5/man/man3/Apache::README.3
shoudn't happen. It misleads since you install Apache/Changes.pod and
Apache/README.pod which can be interpeted as mod_perl base files. And of
course there is no need to install these system wide. All you want is:
Installing /usr/lib/perl5/site_perl/5.005/Apache/Perfmon.pm
Installing /usr/lib/perl5/man/man3/Apache::Perfmon.3
The logfile is opened only once for each apache
subprocess. This is done to reduce the overhead caused by
this module, but it also means that logfile rotation can
be painful.
Why don't you open it at the server startup (when you preload
Apache::Perfmon) and all the children will inherit the opened FH.
Now the name -- it should be different. You've picked a name which is too
generic, while it explores only one side of performance measuring. Doug
has already a module called Apache::TimeIt from his book, whose idea is
more or less the same. It was presented as an example and therefore has
almost no code in it :)
Since I work my self on Apache::Benchmark module, I'm thinking about
putting all the performance monitoring and benchmarking modules under the
same roof. Apache::Benchmark sounds like a good choice to me.
Therefore I would suggest calling your module Apache::Benchmark::CPU and
Apache::Benchmark::Handler (hmm, I think that it can be a good idea to
have these two functions separated, therefore I've suggested these two
different modules).
I know that people aren't favorite of modules whose names are of more than
2 levels deepnees, but in order to insure a healthy ground for the future
emerging modules, this "sacrificing" is a due.
_____________________________________________________________________
Stas Bekman JAm_pH -- Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide http://perl.apache.org/guide
mailto:[EMAIL PROTECTED] http://apachetoday.com http://jazzvalley.com
http://singlesheaven.com http://perlmonth.com perl.org apache.org
