On Sat, Jan 10, 2004 at 07:23:12PM -0500, Jay R. Ashworth wrote:
On Sat, Jan 10, 2004 at 01:10:49PM -0800, Stas Bekman wrote:
*** sysopen error: Permission denied at /usr/src/other/mod_perl-1.99_12/blib/l ib/Apache/compat.pm line 596.
it fails to open the temp file and we don't check it. Besides needing to add the success check, please check why "$TMPDIR/${$}" is not writable by the user you run the test suite with.
I'd have to assume $TMPDIR doesn't exist, since I'm running the make test as root.
Thank ghod for tgrep. TMPDIR falls back to /tmp, and mine, probably because of a drive failure and subsequent unmounting, was 755 instead of 777; I presume that the comment above should actually be "the user your apache runs as"?
Yes, you are correct.
Tested fine this time.
Perfect.
Glenn's right; that should be tested explicitly.
Not sure what you are reffering to (I haven't seen any messages from Glen on the list), but here is the patch that I've just committed:
Index: lib/Apache/compat.pm =================================================================== RCS file: /home/cvs/modperl-2.0/lib/Apache/compat.pm,v retrieving revision 1.94 diff -u -r1.94 compat.pm --- lib/Apache/compat.pm 20 Dec 2003 01:28:43 -0000 1.94 +++ lib/Apache/compat.pm 11 Jan 2004 20:21:35 -0000 @@ -589,7 +589,8 @@ my $tmpfile = "$TMPDIR/${$}" . $TMPNAM++; my $fh = $class->new;
- sysopen($fh, $tmpfile, $Mode, $Perms);
+ sysopen $fh, $tmpfile, $Mode, $Perms
+ or die "failed to open $tmpfile: $!";
$r->pool->cleanup_register(sub { unlink $tmpfile });if ($fh) {
__________________________________________________________________ Stas Bekman JAm_pH ------> Just Another mod_perl Hacker http://stason.org/ mod_perl Guide ---> http://perl.apache.org mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com http://modperlbook.org http://apache.org http://ticketmaster.com
-- Reporting bugs: http://perl.apache.org/bugs/ Mail list info: http://perl.apache.org/maillist/modperl.html
