On Sun, Jan 11, 2004 at 01:45:39PM -0800, Stas Bekman wrote: > Jay R. Ashworth wrote: > [...] > > If I weren't so busy trying to get WebGUI to run overtop it (the > > upgrade of mp2 didn't fix my problem), I'd observe that there are > > probably lots of other sysopens in the scaffold that ought to be checked > > for error handling... but a) I'd probably be encouraged to generate > > patches (:-) and b) I'm probably worng. > > what scaffold you are talking about? There is only one sysopen() call in the > whole modperl-2.0 cvs repository. > > modperl-2.0> grep -Ir sysopen . > ./lib/Apache/compat.pm: sysopen $fh, $tmpfile, $Mode, $Perms > > and we now check the success of this call. And yes, if you find other > unchecked syscalls that are likely to fail, please at least report those. It > should be trivial to fix.
And see? I was right on both counts. :-) Cheers, -- jra -- Jay R. Ashworth [EMAIL PROTECTED] Member of the Technical Staff Baylink RFC 2100 The Suncoast Freenet The Things I Think Tampa Bay, Florida http://baylink.pitas.com +1 727 647 1274 Come see Linux Gazette in our new home: www.linuxgazette.net! -- Reporting bugs: http://perl.apache.org/bugs/ Mail list info: http://perl.apache.org/maillist/modperl.html
