mock wrote:
A while ago I attended an interesting talk by Stas at the Vancouver pm.  The
idea of building an SMTP server using mod_perl was mentioned and the task kind
of appealed to me, so here's my first attempt at it.  Note that it uses
Apache::TieBucketBrigade, which is my attempt at making bucket brigades look
like IO::Handles.  This may or may not be a good idea; I'd appreciate some
feedback.

Cool. It looks nice, but you shouldn't have rushed to release things on CPAN, IMHO.


Why taking over the Apache::SMTP namespace if you don't implement a full SMTP protocol? It's usually a good idea to post a proposal here so we may help to choose a suitable name. If you badly want to put things on CPAN, include _ in the version number so that the PAUSE indexer won't index it.

Besides taking over Apache::SMTP, it should probably live somewhere under Apache::Protocol::. For some ideas see:
http://perl.apache.org/products/apache-modules.html#Module_Naming_Conventions


As for Apache::TieBucketBrigade, it's probably a good idea to make it a part of the mp2 core and implement it in C. There is a plan to provide TIE API for filters as written down at modperl-2.0/todo/features_new

BTW, I'm trying to figure out how to test both of these modules using Apache::Test, but I'm not having a lot of luck. Any pointers would be helpfull.

http://perl.apache.org/docs/general/testing/testing.html
http://www.perl.com/pub/a/2003/05/22/testing.html
modperl-2.0 test suite and several other Apache:: modules on CPAN which now include a test suite.


You want to keep TestTieBucketBrigade.pm out of project/lib and put it under t instead. See the modperl-2.0 test suite.

thanks, and enjoy my sketchy code ;)

code can be found here: http://search.cpan.org/~mock/

__________________________________________________________________ Stas Bekman JAm_pH ------> Just Another mod_perl Hacker http://stason.org/ mod_perl Guide ---> http://perl.apache.org mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com http://modperlbook.org http://apache.org http://ticketmaster.com

--
Report problems: http://perl.apache.org/bugs/
Mail list info: http://perl.apache.org/maillist/modperl.html
List etiquette: http://perl.apache.org/maillist/email-etiquette.html



Reply via email to