On Mon, Feb 23, 2004 at 11:27:33AM -0800, Stas Bekman wrote: > Cool. It looks nice, but you shouldn't have rushed to release things on > CPAN, IMHO. > > Why taking over the Apache::SMTP namespace if you don't implement a full > SMTP protocol? It's usually a good idea to post a proposal here so we may > help to choose a suitable name. If you badly want to put things on CPAN, > include _ in the version number so that the PAUSE indexer won't index it. > > Besides taking over Apache::SMTP, it should probably live somewhere under > Apache::Protocol::. For some ideas see: > http://perl.apache.org/products/apache-modules.html#Module_Naming_Conventions
It should be a full implementation of SMTP, if it isn't then there's a bug. What it doesn't do, is proper queuing, any sort of real validation of the sender or recipient, domain specific configuration, or local delivery. My thought for the namespace was that those sorts of things would be implemented in subclasses - Apache::SMTP::LocalDelivery - and the like. I'm not sure I like the Apache::Protocol:: namespace as it, to my mind at least, doesn't capture the idea that it implements a daemon. I toyed with Apache::Net::Server::Mail::SMTP since it really is just Net::Server::Mail::SMTP bolted on to a handler, but that name space is just fugly ;). I suppose it could be Apache::Server::SMTP or perhaps Apache::Daemon::SMTP but both of those seem somehow redundant; I mean, "Apache::Server?" Apache is a Server. Anyway after agonizing over the namespace for quite some time I decided to just go with simple and to the point Apache::SMTP (although I thought about putting a D on the end for Apache::SMTPD). Anyway, obviously I ate too much lead paint as a child, however I'm certainly willing to move to a different name space if someone thinks there'll be others wanting to camp out in Apache::SMTP. > > As for Apache::TieBucketBrigade, it's probably a good idea to make it a > part of the mp2 core and implement it in C. There is a plan to provide TIE > API for filters as written down at modperl-2.0/todo/features_new Well, I think I've kinda proven it would be usefull. Many of the things I did are kinda hackish in perl. > > >BTW, I'm trying to figure out how to test both of these modules using > >Apache::Test, but I'm not having a lot of luck. Any pointers would be > >helpfull. > > http://perl.apache.org/docs/general/testing/testing.html > http://www.perl.com/pub/a/2003/05/22/testing.html > modperl-2.0 test suite and several other Apache:: modules on CPAN which now > include a test suite. > > You want to keep TestTieBucketBrigade.pm out of project/lib and put it > under t instead. See the modperl-2.0 test suite. > I'm having a little difficulty figuring out how to create request which isn't HTTP. I'll move TestTieBucketBrigade and rerelease just as soon as I figure out how to make Apache::TestRequest do what I want. thanks mock -- Report problems: http://perl.apache.org/bugs/ Mail list info: http://perl.apache.org/maillist/modperl.html List etiquette: http://perl.apache.org/maillist/email-etiquette.html
