On Thu, Jul 29, 1999, Matthias Loepfe wrote:

> > > 1. catch the SIG_PIPE in truerand
> [...] 
> I use the following patch to truerand.c:
> 
> diff -c truerand.c
> /opt/projects/packages/apache/mod_ssl-2.3.9-1.3.6/pkg.contrib/truerand.c
> *** truerand.c  Wed Jul 28 19:20:35 1999
> --- /opt/projects/packages/apache/mod_ssl-2.3.9-1.3.6/pkg.contrib/truerand.c   
> Tue Jan 26 19:36:28 1999
> ***************
> *** 451,461 ****
>       return ((int) (*hash)) & 0xff;
>   }
>   
> - static void done(int s)
> - {
> -     exit(0);
> - }
> - 
>   /*
>    * Main program
>    */
> --- 451,456 ----
> ***************
> *** 464,471 ****
>   {
>       int count;
>   
> -     (void) signal(SIGPIPE, done);
> - 
>       if (argc == 1)
>           count = 0;
>       else
> --- 459,464 ----

Yes, that's exactly what I've comitted this morning for 2.3.11:

Index: truerand.c
===================================================================
RCS file: /e/modssl/cvs/mod_ssl/pkg.mod_ssl/pkg.contrib/truerand.c,v
retrieving revision 1.1
diff -u -r1.1 truerand.c
--- truerand.c  1999/01/27 08:49:16 1.1
+++ truerand.c  1999/07/29 13:59:07
@@ -455,15 +453,23 @@
  * Main program
  */
 
+/* SIGPIPE causes normal exit */
+static void handler(int sig)
+{
+    exit(0);
+}
+
 int main(int argc, char **argv)
 {
     int count;
 
+    signal(SIGPIPE, handler);
     if (argc == 1)
         count = 0;
     else
         count = atoi(argv[1]) + 1;
-   setbuf(stdout, NULL);
+    setbuf(stdout, NULL);
     while (--count)
         fprintf(stdout, "%c", randbyte());
 }

So your fix is already included for 2.3.11. Thanks for your feedback.  I'll
also try to work on your two other suggested patches (the renego-patches and
the proxy-patches) for 2.4.0.
                                       Ralf S. Engelschall
                                       [EMAIL PROTECTED]
                                       www.engelschall.com
______________________________________________________________________
Apache Interface to OpenSSL (mod_ssl)                   www.modssl.org
User Support Mailing List                      [EMAIL PROTECTED]
Automated List Manager                            [EMAIL PROTECTED]

Reply via email to