[BugDB] Bogus warning "Failed to acquire global mutex" on Win32 (PR#225)

[modssl-bugdb]

Full_Name: Tran Duc Trung
Version: 2.3.10-1.3.6
OS: Win32
Submission from: host.133.52.ixos.de (149.235.133.52)


mod_ssl on Win32 emits a warning "Failed to acquire global mutex"
in ssl.log. This is a bug in ssl_engine_mutex.c

...
rc = ap_acquire_mutex((mutex *)mc->nMutexSEMID));
...

ap_acquire_mutex() returns 0 (zero) if it succeeds, not TRUE/FALSE.

Patch follows

---8<---
@@ -336,7 +336,7 @@
     rc = semop(mc->nMutexSEMID, sb, 2);
 #endif
 #ifdef SSL_HAVE_W32SEM
-    rc = ap_acquire_mutex((mutex *)mc->nMutexSEMID);
+    rc = (0 == ap_acquire_mutex((mutex *)mc->nMutexSEMID)); /* 1999-07-29 trung
*/
 #endif
 #endif
     return rc;


______________________________________________________________________
Apache Interface to OpenSSL (mod_ssl)                   www.modssl.org
User Support Mailing List                      [EMAIL PROTECTED]
Automated List Manager                            [EMAIL PROTECTED]