On Tue, Oct 12, 1999, Martin Kraemer wrote:

> The method to exit from apache when mm cannot open the semaphore file
> (e.g., because of permission problems) seems rather drastic to me:
> 
> main/alloc.c:628:
>         if ((mm = ap_mm_create(mm_size, mm_path)) == NULL) {
>             fprintf(stderr, "Ouch! ap_mm_create(%d, \"%s\") failed\n", mm_size, 
>mm_path);
>             err1 = ap_mm_error();
>             if (err1 == NULL)
>                 err1 = "-unknown-";
>             err2 = strerror(errno);
>             if (err2 == NULL)
>                 err2 = "-unknown-";
>             fprintf(stderr, "Error: MM: %s: OS: %s\n", err1, err2);
> ------->    abort();
>             exit(1);
>         }
> 
> I would prefer if the program would simply exit with an unsuccessful
> exit code after printing the error message.

Ok, I've removed the abort() for mod_ssl 2.4.6

> PS: are there more abort()s hidden in there? In alloc.c, there are many
> of the assert() class ("this must *NEVER* happen" type of errors), most
> of them wrapped in #ifdef POOL_DEBUG. But ordinary permission problems
> should definitely NOT trigger an abort().

There are more abort()s, but not from me (EAPI), of course.
I usually use abort() only in special situations...

                                       Ralf S. Engelschall
                                       [EMAIL PROTECTED]
                                       www.engelschall.com
______________________________________________________________________
Apache Interface to OpenSSL (mod_ssl)                   www.modssl.org
User Support Mailing List                      [EMAIL PROTECTED]
Automated List Manager                            [EMAIL PROTECTED]

Reply via email to