Dear Mr. Engelschall.
Thank you for your rapid follow up and patch.

I've checked your patch and it work fine.

But I have 2 suggesions for the code.
1. MD5 always generate fix length (128bit = 16octets) hash data.
   So, patch for SSL_set_session_id_context() can be:
   SSL_set_session_id_context(ssl, (unsigned char *)cpVHostMD5, 16);
   This make code more smaller and more efficient.

2. Must check SSL_set_session_id_context()'s return value.
   Currently, openssl implementation restricts SID context
   length to 32 octets, but in future, we could not certify
   it.
   To check return value, we could easily clear the reason
   of problems.

Thanks

Ryu Inada <[EMAIL PROTECTED]>

P.S.
If you add my name in CHANGES log, please add
[EMAIL PROTECTED] also. 
He is investigate SSLed Apache on NT box, and found out what was
happen.
I've checked on Solaris 7 box in same time he did.



______________________________________________________________________
Apache Interface to OpenSSL (mod_ssl)                   www.modssl.org
User Support Mailing List                      [EMAIL PROTECTED]
Automated List Manager                            [EMAIL PROTECTED]

Reply via email to