On Fri, May 05, 2000, Jacob Cohen wrote:
> The placement of the ssl_scache_expire() call in ssl_scache_init() is above
> the vendor hook for scache_init.
> ssl_scache_expire() also has a vendor hook in it for scache_expire. I
> believe that the hook for scache_init should be called before the hook for
> scache_expire.
> My vendor expire() function depends on there being a memory pool available
> from which to allocate memory to do various things. Since the expire() hook
> doesn't pass in a pool pointer, I have to get it from the module
> configuration context, and that, naturally, is set up in the scache_init
> vendor function.
> So I have been modifying ssl_scache_init() to have the scache_init vendor
> hook above the call the ssl_scache_expire(). It seems to work just as well
> either way.
The ssl_scache_expire() call in ssl_scache_init() is a left-over
which I just have overlooked. I've now comitted for mod_ssl 2.6.5:
Index: ssl_engine_scache.c
===================================================================
RCS file: /e/modssl/cvs/mod_ssl/pkg.apache/src/modules/ssl/ssl_engine_scache.c,v
retrieving revision 1.51
diff -u -d -r1.51 ssl_engine_scache.c
--- ssl_engine_scache.c 2000/04/16 10:09:43 1.51
+++ ssl_engine_scache.c 2000/05/06 07:02:39
@@ -86,7 +86,6 @@
ssl_scache_dbm_init(s, p);
else if (mc->nSessionCacheMode == SSL_SCMODE_SHM)
ssl_scache_shm_init(s, p);
- ssl_scache_expire(s, time(NULL));
#ifdef SSL_VENDOR
ap_hook_use("ap::mod_ssl::vendor::scache_init",
@@ -338,6 +337,8 @@
}
#endif
ssl_mutex_off(s);
+
+ ssl_scache_dbm_expire(s, time(NULL));
return;
}
Ralf S. Engelschall
[EMAIL PROTECTED]
www.engelschall.com
______________________________________________________________________
Apache Interface to OpenSSL (mod_ssl) www.modssl.org
User Support Mailing List [EMAIL PROTECTED]
Automated List Manager [EMAIL PROTECTED]
