Ricardo SIGNES wrote:
* Andy Lester <[EMAIL PROTECTED]> [2005-08-22T15:07:47]

RJBS and I are going to put some tests into Module::Starter to check for
boilerplate.  Watch for it tomorrow, maybe tonight.


Just a little while ago I uploaded 1.41_01, which adds:

  * t/boilerplate.t
  * some bug fixes
  * simple email address obfuscation
  * hook for new, improved plugin architecture

The boilerplate check is simple, but should catch the main offenses --
as long as people test before uploading.

I've played with the new version a bit on Debian Linux and Windows. Just a few very very minor comments:

1) I'm not a big fan of email obfuscation, though I might be in the minority. Most forms are just as easy to parse as a regular email address. And obfuscation feels too much like surrendering. Just my opinion. But an option might be nice if not too much trouble.

2) I like the boilerplate tests in M::S. It feels like an appropriate place since M::S puts it in, it might as well create tests to make sure it gets removed. However, I use M::S a lot for creating quick test distros, and that sometimes makes the failing tests annoying. But my usage is probably unusual in this reguard. It'd be nice if there were an option to diable it, but I can easily create a wrapper that "fixes" it for my purposes.

3) I goofed on the commandline and typod `module-starter --module Foo --mb --version` and scratched my head for a while looking for the 'Foo' directory. Should have type 'verbose'. Maybe 'version' could be an exclusive option, generating an error in the presence of other options? Or I should learn to type better.

4) Since M::S can generate distros with a Build.PL it might be nice if it also included one. ;)

# vi:et:sw=4 ts=4
use strict;
use warnings;
use 5.6.1;
use Module::Build;

my $build = Module::Build->new(

    module_name  => 'Module::Starter',
    license      => 'perl',
    dist_author  => [
        'Andy Lester <[EMAIL PROTECTED]>',
        'Ricardo SIGNES <[EMAIL PROTECTED]>',
    ],


    script_files => [ 'bin/module-starter' ],

    requires     => {
        'Test::More'        => 0,
        'ExtUtils::Command' => 0,
        'File::Spec'        => 0,
        'Getopt::Long'      => 0,
        'Pod::Usage'        => 0,
    },
);

$build->create_build_script;
__END__


*NOTE you must also add to Makefile.PL

WriteMakefile(
    ...
    PL_FILES            => {}, # don't auto expand 'Build.PL'
);

And, optionally, do a `perl Build.PL` & `perl Build distmeta` to update your META.yml file.

Reply via email to