On Sep 28, 2008, at 08:25, David E. Wheeler wrote:

As for the rest of your patch David, would you mind porting it forward to fit this refactor? I think the API you'll want is basically like: _make_accessor($property, %opts).

Yes, I'll do that, but I'm less inclined to contribute in the future if you force me to rewrite my patches because you discover, thanks to my patch, that you don't like the current code, so you change it and force me to rewrite. Please, if you're going to do that, wait until my code is committed so that there's less work to be done overall.

Eric, are you going to commit your patch so I can finish re-doing my and resubmitting it?

Also, have we settled on 4- or 2- space indents yet? At this point, though I prefer 4-space, I don't really care enough to press it, as long as tabs go away.

Thanks,

David

Reply via email to