On Thu, Nov 26, 2009 at 1:43 AM, Adam Kennedy <adamkennedybac...@gmail.com> wrote: > Addition to David's reply, the use of xt was suggested as a > convenience (not as a requirement) that tools may or may not choose to > use to indicate tests that run during RELEASE_TESTING. They won't > define tests that MUST be run during RELEASE_TESTING.
How about this: (1) We add a "testrelease" action that sets RELEASE_TESTING and calls a list of other testing actions (2) We add a 'testxt' action that runs tests in xt/; this is common enough now that we might as well make it easy (3) We add a 'release_test_actions' parameter to set the list. This would default to qw/test testxt testpod distcheck disttest/ but could be overridden in arguments to new() I suggest this approach as some people may want pod testing, others not, some may put tests in xt, others not, some may have custom actions, others not. In the end, we set some reasonable defaults and let people change them in a way that doesn't require subclassing ACTION_testrelease just to get a different list of actions. I'll let others bikeshed the default list in #3 as I don't really care. (It gets me thinking is that 'Build release' would be easy to do similarly, either culminating in "dist" or -- if we have CPAN::Upload -- in an actual release to CPAN.) -- David