> On 18 Jan 2018, at 1:21 pm, Graham Dumpleton <graham.dumple...@gmail.com> > wrote: > > > >> On 18 Jan 2018, at 9:15 am, Graham Dumpleton <graham.dumple...@gmail.com >> <mailto:graham.dumple...@gmail.com>> wrote: >> >> >> >>> On 17 Jan 2018, at 10:51 pm, Jesus Cea <j...@jcea.es <mailto:j...@jcea.es>> >>> wrote: >>> >>> On 17/01/18 15:00, Graham Dumpleton wrote: >>>>> """ if (!PyErr_Occurred() && !aborted) { if (Adapter_output(self, >>>>> "", 0, NULL, 0)) self->result = OK; } """ >>>>> >>>>> I am not sure why "Adapter_output()" is called with NOOP operation >>>>> (maybe to signal "end of stream", but then I don't know why it is >>>>> only done when no python error occurred), but "self->result=OK" >>>>> requires "aborted==0". This is not going to happen if we have >>>>> "aborted==1". >>>> >>>> Apache needs it to ensure that a 100-continue response is flushed out >>>> correctly if browser was expecting it, otherwise things get messed >>>> up. >>> >>> Then my question is why is that ONLY done when "!PyErr_Occurred()". It >>> should be done always, at least if "aborted==0". >> >> My recollection is that Apache would normally not generate a 100-continue >> for a non 200 response and would return the non 200 error immediately. >> Forcing the 100-continue, which is what that call would do, means not >> working the same as Apache would normally and want to avoid that resulting >> in problems with how Apache handles things. I wouldn't have qualified it if >> I hadn't had some issue previously. > > My linking this to 100-continue is completely wrong. The 100-continue applies > to reading request input, not output. It may instead relate to ensuring a 0 > chunk is sent at end of response data when chunking is used, I really can't > remember now but am starting to look through code. Unfortunately the commit > comments I can find so far aren't particularly useful as this code change was > made then backed out and then added again. The comment when it was added > again doesn't say anything useful so may have to find original commit.
Actually, it is also possible that it is ensuring headers are flushed out when there was no response content. > Graham > >> Graham >> >>>> It sort of sounds plausible. I am travelling at the moment and don't >>>> have a good amount of time to sit down and check it. For now just >>>> suggest keep testing with it and see how it goes. I will try and find >>>> some time over the next week to look at it more. >>> >>> Much appreciated, Graham. >>> >>> I have my patch in production. Good so far. Probably wrong if "100 >>> continue", as described at the top of this email, but I don't use it. I >>> will implement it when you clarify. >>> >>> -- >>> Jesús Cea Avión _/_/ _/_/_/ _/_/_/ >>> j...@jcea.es <mailto:j...@jcea.es> - http://www.jcea.es/ >>> <http://www.jcea.es/> _/_/ _/_/ _/_/ _/_/ _/_/ >>> Twitter: @jcea _/_/ _/_/ _/_/_/_/_/ >>> jabber / xmpp:j...@jabber.org <xmpp:j...@jabber.org> _/_/ _/_/ _/_/ >>> _/_/ _/_/ >>> "Things are not so easy" _/_/ _/_/ _/_/ _/_/ _/_/ _/_/ >>> "My name is Dump, Core Dump" _/_/_/ _/_/_/ _/_/ _/_/ >>> "El amor es poner tu felicidad en la felicidad de otro" - Leibniz >>> >>> -- >>> You received this message because you are subscribed to the Google Groups >>> "modwsgi" group. >>> To unsubscribe from this group and stop receiving emails from it, send an >>> email to modwsgi+unsubscr...@googlegroups.com >>> <mailto:modwsgi+unsubscr...@googlegroups.com>. >>> To post to this group, send email to modwsgi@googlegroups.com >>> <mailto:modwsgi@googlegroups.com>. >>> Visit this group at https://groups.google.com/group/modwsgi >>> <https://groups.google.com/group/modwsgi>. >>> For more options, visit https://groups.google.com/d/optout >>> <https://groups.google.com/d/optout>. -- You received this message because you are subscribed to the Google Groups "modwsgi" group. To unsubscribe from this group and stop receiving emails from it, send an email to modwsgi+unsubscr...@googlegroups.com. To post to this group, send email to modwsgi@googlegroups.com. Visit this group at https://groups.google.com/group/modwsgi. For more options, visit https://groups.google.com/d/optout.
