Sorry, forgot to add, its pull request: https://github.com/mojohaus/xml-maven-plugin/pull/22
On Saturday, August 12, 2017 at 7:35:22 PM UTC+10, Jochen Wiedmann wrote: > > On Thu, Aug 10, 2017 at 7:00 AM, Ross Lamont > > > What's the process around getting pull requests processed for a plugin? > > I've made some improvements/fixes to xml-maven-plugin, and I have a few > more > > to add after this lot have made it to the master. > > > > Hope I'm not being too impatient! > > If you are referring to > > https://github.com/mojohaus/xml-maven-plugin/pull/18 > > Here's what I think about it: > > * Modifies 20 files, which is way too much for a single pull request. > * The PR's intention is unclear. At least the title definitely is: > "Issue #16, #17 and #20 test cases and fixes" Now, which is it? > > Jochen > > > > -- > The next time you hear: "Don't reinvent the wheel!" > > > http://www.keystonedevelopment.co.uk/wp-content/uploads/2014/10/evolution-of-the-wheel-300x85.jpg > > -- You received this message because you are subscribed to the Google Groups "mojohaus-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/mojohaus-dev/33ba4842-9794-4e8e-a0a1-c8d5f6912207%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
