Thanks for reviewing this, I would say most of the tools (checkstyle, spotbugs etc..) usually do not check test sources. Most of the time test sources try to test backward compat with old api. so it sounds like a good default.
On Wed, 10 Feb 2021 at 19:14, Falko Modler <[email protected]> wrote: > Hi Oliver! > > I find this a bit unfortunate/problematic: > > https://github.com/mojohaus/animal-sniffer/issues/142#issuecomment-776531298 > > There should be a very prominent note in the changelog to make people > aware that they now have to enable checkTestClasses. > Otherwise people that are using this feature today and rely on it being > active by default will actually loose this check when updating without > noticing. > > Please note that this is *not* a -1 though! :-) > > Cheers, > Falko > > -- > You received this message because you are subscribed to the Google Groups > "mojohaus-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To view this discussion on the web visit > https://groups.google.com/d/msgid/mojohaus-dev/730c4e13-b8ce-45ac-8139-2ae2d8b668eb%40gmx.net > <https://groups.google.com/d/msgid/mojohaus-dev/730c4e13-b8ce-45ac-8139-2ae2d8b668eb%40gmx.net?utm_medium=email&utm_source=footer> > . > -- Olivier Lamy http://twitter.com/olamy | http://linkedin.com/in/olamy -- You received this message because you are subscribed to the Google Groups "mojohaus-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/mojohaus-dev/CAPoyBqQ-upeik5%2BjyyguvaRUYpWoWuq401cGarVnQ07vr%2BZSQg%40mail.gmail.com.
