It seems like this release sets Java8 as a minimum [1], this should probably be mentioned somewhere in the docs too.
[1] https://github.com/mojohaus/animal-sniffer/commit/2d1efa5c790cf375d7f6fc620d4f2695b9fe0476#diff-9c5fb3d1b7e3b0f54bc5c4182965c4fe1f9023d449017cece3005d3f90e8e4d8R183 ср, 10 февр. 2021 г. в 16:13, Olivier Lamy <[email protected]>: > Thanks for reviewing this, > I would say most of the tools (checkstyle, spotbugs etc..) usually do not > check test sources. Most of the time test sources try to test backward > compat with old api. > so it sounds like a good default. > > > On Wed, 10 Feb 2021 at 19:14, Falko Modler <[email protected]> wrote: > >> Hi Oliver! >> >> I find this a bit unfortunate/problematic: >> >> https://github.com/mojohaus/animal-sniffer/issues/142#issuecomment-776531298 >> >> There should be a very prominent note in the changelog to make people >> aware that they now have to enable checkTestClasses. >> Otherwise people that are using this feature today and rely on it being >> active by default will actually loose this check when updating without >> noticing. >> >> Please note that this is *not* a -1 though! :-) >> >> Cheers, >> Falko >> >> -- >> You received this message because you are subscribed to the Google Groups >> "mojohaus-dev" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected]. >> To view this discussion on the web visit >> https://groups.google.com/d/msgid/mojohaus-dev/730c4e13-b8ce-45ac-8139-2ae2d8b668eb%40gmx.net >> <https://groups.google.com/d/msgid/mojohaus-dev/730c4e13-b8ce-45ac-8139-2ae2d8b668eb%40gmx.net?utm_medium=email&utm_source=footer> >> . >> > > > -- > Olivier Lamy > http://twitter.com/olamy | http://linkedin.com/in/olamy > > -- > You received this message because you are subscribed to the Google Groups > "mojohaus-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To view this discussion on the web visit > https://groups.google.com/d/msgid/mojohaus-dev/CAPoyBqQ-upeik5%2BjyyguvaRUYpWoWuq401cGarVnQ07vr%2BZSQg%40mail.gmail.com > <https://groups.google.com/d/msgid/mojohaus-dev/CAPoyBqQ-upeik5%2BjyyguvaRUYpWoWuq401cGarVnQ07vr%2BZSQg%40mail.gmail.com?utm_medium=email&utm_source=footer> > . > -- Sincerely yours, Krosheninnikov Artem. -- You received this message because you are subscribed to the Google Groups "mojohaus-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/mojohaus-dev/CAGTk7vgZg9SGV1VvmQR08p4Ct2Zh2y5AVC1rjWB0TKYbdBVRqA%40mail.gmail.com.
