Thanks for all the feedback! What about this <https://github.com/s1037989/minion/commit/78d951cc99bac93599633adbe36e45573a614ab0> ?
Two of my own comments: 1) Should I pass the url in as a parameter to a function, or is it OK placing it within the function as it is? 2) I have it refreshing every 10 minutes (I use 1000 * 60 * 10 to be more clear about the number... is this your preferred style?) but every minute if it fails. I figured if it fails we should retry sooner than 10 minutes. On Tue, Apr 17, 2018 at 11:34 AM, sri <kra...@gmail.com> wrote: > What else can I do for this commit to make it acceptable to close #70? >> > > And of course general formatting. Your use of the + operator without > whitespace seems very arbitrary. > > -- > sebastian > > -- > You received this message because you are subscribed to the Google Groups > "Mojolicious" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to mojolicious+unsubscr...@googlegroups.com. > To post to this group, send email to mojolicious@googlegroups.com. > Visit this group at https://groups.google.com/group/mojolicious. > For more options, visit https://groups.google.com/d/optout. > -- You received this message because you are subscribed to the Google Groups "Mojolicious" group. To unsubscribe from this group and stop receiving emails from it, send an email to mojolicious+unsubscr...@googlegroups.com. To post to this group, send email to mojolicious@googlegroups.com. Visit this group at https://groups.google.com/group/mojolicious. For more options, visit https://groups.google.com/d/optout.
