On Fri, 30 Nov 2012 20:50:54 +0100 Sonny Karlsson <[email protected]> wrote:
> I'm answering a bit late, but I definitely think this functionality > should be part of the monkey lib so I've created a patch. This patch > adds a function for fetching a request header (mklib_get_request_header) > inside a cb_data or cb_close (untested) callback. The function solves > this problem almost the same way, but using the headers_toc (headers > table of content) instead. Hi Certainly a good function to add. Ed, I wish you'd have waited a day or two for me to have time to review this ;) Please revert the current version. @Sonny: - please use the MKLIB_TRUE, MKLIB_FALSE return values for consistency - on a cursory look, this looks like it's duplicated code from elsewhere - I'm not sure. Is it? - all mklib functions are documented. Please submit a man page for the new function - the new function wasn't exported to the library (MK_EXPORT), so it won't be accessible to users as is If you don't have the required asciidoc setup, submitting the text source is enough, I can generate the man page. (under man/asc-src/). - Lauri PS: Re-sending, because this mail didn't appear on the list after a few hours. _______________________________________________ Monkey mailing list [email protected] http://lists.monkey-project.com/listinfo/monkey
