On Sun, 2 Dec 2012 12:31:35 +0100
Sonny Karlsson <[email protected]> wrote:

> > - on a cursory look, this looks like it's duplicated code from elsewhere - 
> > I'm not sure. Is it?
> 
> There is similar code in mk_request.c, but it toggles a 'status' flag on
> so entries they won't be read twice. I can see numerous problems with
> that in a library setting. Monkey itself access some of the headers
> when populating session_request/client_session structs, which are not
> public. The mk_request.c version is also exposed in the plugin api,
> possibly hiding even more headers. To access all headers I must write it
> like this.

OK. Maybe for some later (partial) consolidation, this is good for now.

> > If you don't have the required asciidoc setup, submitting the text source 
> > is enough, I can generate the man page. (under man/asc-src/).
> 
> I'd be grateful if you could generate it, the asciidoc installation
> requires 1.2 GB and I'd rather use the space on my raspberry pi for
> something else.

Mine is something like 1.5 mb, but I built it from source. I'll do that once 
the patch is in master.

Ack for this patch. Ed, please push this one instead of the old one.

- Lauri
_______________________________________________
Monkey mailing list
[email protected]
http://lists.monkey-project.com/listinfo/monkey

Reply via email to