http://bugzilla.novell.com/show_bug.cgi?id=543537
User [email protected] added comment http://bugzilla.novell.com/show_bug.cgi?id=543537#c5 --- Comment #5 from Andrés G. Aragoneses <[email protected]> 2009-10-05 09:01:29 MDT --- Hey Marek, thanks for your comments! See inline: (In reply to comment #2) > ... > However, it needs some work yet. Forgot to say, that the patch also lacks a unit test. I'll work on that too. (In reply to comment #4) > #1: You cannot use > string mscorlib_name = core_lib_name + ", Version=2.0.0.0, Culture=neutral, > PublicKeyToken=b77a5c561934e089"; Why? How should I identify and white list this kind of system assemblies? > #2: Environment.Exit cannot be used Why? I see that it's used in other places. Let me guess: you say that because you prefer gmcs to still parse the sources and give other errors besides these ones? > Why do you need modify Makefile ? Well, if we commit this fix, the build of mono will fail as gmcs is now more strict. For example, one of the changes I had to do: Index: trunk/mcs/tools/gacutil/Makefile =================================================================== --- trunk/mcs/tools/gacutil/Makefile (revisión: 143331) +++ trunk/mcs/tools/gacutil/Makefile (copia de trabajo) @@ -2,7 +2,7 @@ SUBDIRS = include ../../build/rules.make -LOCAL_MCS_FLAGS = -r:Mono.Security.dll +LOCAL_MCS_FLAGS = -r:System.dll -r:Mono.Security.dll PROGRAM = $(topdir)/class/lib/$(PROFILE)/gacutil.exe Index: trunk/mcs/tools/security/Makefile =================================================================== --- trunk/mcs/tools/security/Makefile (revisión: 143331) +++ trunk/mcs/tools/security/Makefile (copia de trabajo) @@ -3,7 +3,7 @@ DIST_ONLY_SUBDIRS = certview include ../../build/rules.make -LOCAL_MCS_FLAGS = /lib:$(topdir)/class/lib/$(PROFILE) -r:Mono.Security.dll +LOCAL_MCS_FLAGS = /lib:$(topdir)/class/lib/$(PROFILE) -r:Mono.Security.dll -r:System.dll SECURITY_PROGRAMS = secutil.exe cert2spc.exe sn.exe makecert.exe chktrust.exe \ signcode.exe setreg.exe certmgr.exe caspol.exe permview.exe mozroots.exe -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. _______________________________________________ mono-bugs maillist - [email protected] http://lists.ximian.com/mailman/listinfo/mono-bugs
