Hi Chistian, Your patch is full of very different kind of changes, some are simple, others require some thought about. So let's sort them into smaller and centered patches.
For example, the ones changing printf style calls are mostly ok and should be committed on their own. Then we can see the warnings changes, the io retry stuff and finally what looks like real bugs. What do you think about it? Rodrigo On Fri, Jul 24, 2009 at 2:02 AM, Christian Hergert <ch...@dronelabs.com>wrote: > Round 2, > > * Moved TEMP_FAILURE_RETRY macro to mono/utils/mono-io-portability.h. > * Removed #ifndef PLATFORM_MACOSX for now. > > -- Christian > > > > > > On Jul 23, 2009, at 8:24 PM, Geoff Norton wrote: > > On 23-Jul-09, at 11:02 PM, Christian Hergert wrote: >> >> Hello, >>> >>> In an effort to get more familiar with some of the code-base, I went >>> through and fixed some of the pesky compiler warnings for the runtime. >>> Attached is a patch for said warnings. >>> >>> If anyone has suggestions on how to better fix the warnings, please send >>> them my way and I'll adjust the patch as needed. >>> >>> >> #1: Having tons of >> +#ifndef TEMP_FAILURE_RETRY >> >> is sucky, localize it into mono/utils/somewhere-logical.h and include it >> around >> >> >> #2: lots of: >> +#ifndef PLATFORM_MACOSX >> FILE *fp; >> +#endif >> >> impedes readability (for me) just for 1 platform, not sure its worth it. >> >> As for the rest, it looks sane, but I'll let the runtime guys weigh in. >> >> -g >> >> > > _______________________________________________ > Mono-devel-list mailing list > Mono-devel-list@lists.ximian.com > http://lists.ximian.com/mailman/listinfo/mono-devel-list > >
_______________________________________________ Mono-devel-list mailing list Mono-devel-list@lists.ximian.com http://lists.ximian.com/mailman/listinfo/mono-devel-list
