In message <[EMAIL PROTECTED]> on Fri, 10 Feb 2006 15:15:13 -0600, Timothy Brownawell <[EMAIL PROTECTED]> said:
tbrownaw> On Fri, 2006-02-10 at 19:26 +0100, Richard Levitte - VMS Whacker wrote: tbrownaw> > What would be needed is perhaps have approve avoid adding tbrownaw> > a branch cert for a branch the revision isn't already in... tbrownaw> tbrownaw> Um, I think that's the entire purpose of approve. It tbrownaw> basically says, "I, so-and-so, approve revision xxxxxxxx for tbrownaw> inclusion into branch aaaa.bbbb.cccc.". Yeah, the only problem, as far as I see it, is that approve takes --branch, so for example, I could very easily say something like: monotone approve --branch=net.venge.monotone.approved.linux \ 6e87084a87413eed2c31100054ff8d5045f0be4d If that gets repeated a few, do you know what kind of graph that branch (which I invented on the spot) would have? Maybe I worry too much, but consider if someone mistakenly connects the revision to another unrelated branch by using approve unwisely? I think approve should at least warn if the given branch doesn't match one of the branch certs already attached to the revision. Cheers, Richard ----- Please consider sponsoring my work on free software. See http://www.free.lp.se/sponsoring.html for details. -- Richard Levitte [EMAIL PROTECTED] http://richard.levitte.org/ "When I became a man I put away childish things, including the fear of childishness and the desire to be very grown up." -- C.S. Lewis _______________________________________________ Monotone-devel mailing list Monotone-devel@nongnu.org http://lists.nongnu.org/mailman/listinfo/monotone-devel