Am 06.08.2010 00:30, schrieb Stephen Leake:
> Thomas Keller <[email protected]> writes:
>> One might deprecate the reader functionality packets other than keys
>> though.
> 
> The top level code in cmd_packet.cc makes no distinction between key and
> other packets. But we could delete the non-key operations from packet.hh
> packet_consumer.

Yes, this is what I meant and what we should do some time.

> There is already an 'automate read_packets' command!
> 
> So I think 'automate put_pub_key" is already implemented.

Kind of. Surely you can put public keys through read_packets, but as
this uses the aforementioned packet_consumer as well which might be
refactored or even replaced some time in the future, I'm not sure if its
a good idea to use that at all. Beside that its not obvious to the
implementor that the orthogonal action to get_pubkey and remove_pubkey
is read_packets. Maybe its time to do this command deprecation thing
earlier, i.e. introduce put_pubkey nonetheless and deprecate automate
read_packets, while having doubled functionality for the time until
read_packets gets removed completely, i.e. in 2.0.

> Unless the point was to have some other format for the input. Bug 30345
> doesn't say what format is expected. ASCII-armored was mentioned in
> chat, but I'm not sure that's a format spec?

No, the input to put_pubkey can basically keep the same - I don't know
if ascii-armored is the right term for this either, basically it should
accept what pubkey spits out :)

Thomas.

-- 
GPG-Key 0x160D1092 | [email protected] | http://thomaskeller.biz
Please note that according to the EU law on data retention, information
on every electronic information exchange might be retained for a period
of six months or longer: http://www.vorratsdatenspeicherung.de/?lang=en


Attachment: signature.asc
Description: OpenPGP digital signature

_______________________________________________
Monotone-devel mailing list
[email protected]
http://lists.nongnu.org/mailman/listinfo/monotone-devel

Reply via email to