Am 18.08.10 10:00, schrieb Stephen Leake: > Stephen Leake <[email protected]> writes: > >> Thomas Keller <[email protected]> writes: > >>> 1) Please rename pubkey to get_public_key > > Done. > >>> rename genkey to generate_key. > > Done. > >>> 3) Please also implement put_public_key. > > Done. > > I duplicated the read_packets implementation, and deleted the non-key > stuff. > > There is a test in tests/key_management that shows no error when the > input stream is not a packet. I was attempting to show that the error > message was reasonable, so this was a surprise. This is not new behavior > ('automate read_packets' does the same), but perhaps we should try to > fix it? > > We could also go thru all the tests and monotone.texi, and change > read_packets to put_public_key where possible. But I think that should > wait until we actually have a deprecation mechanism. > >>> 4) The docs on drop_public_key should be tweaked a bit > > done. > >>> 5) Would it be a good idea to rename common/test_utils_inventory.lua to >>> something more generic now that this is used a couple of times outside >>> the basic inventory tests? Alternatively the common stuff could be moved >>> out of this file. > > Done; common stuff moved to tests/common/basic_io.lua
Final notes: --- monotone.texi f7e524e86db1abd48eb792525bd88f7b1a74c5dd +++ monotone.texi 38b7bd62df7bd79889eaee04963db22b607ccfb7 @@ -1,4 +1,4 @@ -\input texinfo @c -*-texinfo-*- +0\input texinfo @c -*-texinfo-*- @c %**start of header The "0" came in here by accident, right? Other than that it looks ready for merge to me - any other opinions? Tim? Derek? Thomas. -- GPG-Key 0x160D1092 | [email protected] | http://thomaskeller.biz Please note that according to the EU law on data retention, information on every electronic information exchange might be retained for a period of six months or longer: http://www.vorratsdatenspeicherung.de/?lang=en
signature.asc
Description: OpenPGP digital signature
_______________________________________________ Monotone-devel mailing list [email protected] http://lists.nongnu.org/mailman/listinfo/monotone-devel
