I'm sorry, it was not Ryan's code, but my own adaptation which broke.
On Nov 21, 9:14 pm, Vic <[email protected]> wrote: > For example Ryan Florence's FitText plugin has this line: > this.container = (typeof this.options.container == 'element') ? > this.options.container : > document.id(this.element.getParent('.'+this.options.container)) ; > which gives the error 'this.container is not defined' later on, > changing this to typeOf(this.options.container) == 'container' fixes > this. > > On Nov 21, 8:55 pm, Ryan Florence <[email protected]> wrote: > > > > > Lolnewb for doing it exactly the way fx.tween did. Gimme a break. > > > Sent from my iPhone > > > On Nov 21, 2010, at 11:51 AM, Christoph Pojer <[email protected]> > > wrote: > > > > Yeah, but it also means that you used a bad coding style (getters that > > > act as setters, wtf?) :P In any case, it is our fault for even > > > providing such an API. This change was really intended to make the > > > code you write with MooTools even more expressive. > > > > On Nov 21, 7:32 pm, Ryan Florence <[email protected]> wrote: > > >> Getters not setting broke several of my classes, so it does require > > >> additional work in some cases even if it "shouldn't" > > > >> Sent from my iPhone > > > >> On Nov 21, 2010, at 11:25 AM, Oskar Krawczyk <[email protected]> > > >> wrote: > > > >>> It really shouldn't require any additional work. > > > >>> On 2010-11-21, at 18:04, Vic wrote: > > > >>>> Thank you Christoph, > > > >>>> I have upgraded using the compatibillity layer, still this requires > > >>>> some extra work with some of the plugins, but indeed is less painfull > > >>>> than I imagined this way, thanks for all the hard work to all the > > >>>> MooTools team-members! > > > >>>> Vic > > > >>>> On Nov 21, 12:16 pm, Christoph Pojer <[email protected]> > > >>>> wrote: > > >>>>> Alternatively, if it is just about data-properties you can also just > > >>>>> put this after mootools core and before your own code: > > > >>>>> Selectors.RegExps.combined = (/\.([\w-]+)|\[([\w-]+)(?:([!*^$~|]?=) > > >>>>> (["']?)([^\4]*?)\4)?\]|:([\w-]+)(?:\(["']?(.*?)?["']?\)|$)/g); > > > >>>>> However, I'd advice you to upgrade to 1.3. It is easy and painless and > > >>>>> brings you a lot more new features. > > > >>>>> On Nov 21, 12:13 pm, Vic <[email protected]> wrote: > > > >>>>>> Thank you Oskar, I will look into both options. > > > >>>>>> On Nov 21, 12:05 pm, Oskar Krawczyk <[email protected]> wrote: > > > >>>>>>> Ah, I see, yes, you're right. > > > >>>>>>> Well you've got two solutions here: > > > >>>>>>> 1. Use Slick with 1.2.5 using @cpojer's solution > > >>>>>>> -https://gist.github.com/361474 > > >>>>>>> 2. Use 1.3-compat so your 1.2 scripts work AND you get all the new > > >>>>>>> 1.3 awesomeness > > > >>>>>>> Best, > > >>>>>>> Oskar > > > >>>>>>> On 2010-11-21, at 11:55, Vic wrote: > > > >>>>>>>> I know, but that IS the problem, see this updated version: > > >>>>>>>>http://jsfiddle.net/victor/AWfeD/1/ > > > >>>>>>>> it should only target the last div, because both selectors target > > >>>>>>>> the > > >>>>>>>> 'second' div > > > >>>>>>>> On Nov 21, 11:01 am, Oskar Krawczyk <[email protected]> > > >>>>>>>> wrote: > > >>>>>>>>> Works fine in 1.2.5 as well. > > > >>>>>>>>> Your example adds colors to both divs, the top one and the bottom. > > > >>>>>>>>> On 2010-11-21, at 10:55, Vic wrote: > > > >>>>>>>>>> I now see that it does work correctly in MooTools 1.3, must have > > >>>>>>>>>> something to do with slick? Still I would love to be able to do > > >>>>>>>>>> this > > >>>>>>>>>> in my 1.2.4 code as well. This particular project cannot upgrade > > >>>>>>>>>> yet. > > > >>>>>>>>>> On Nov 21, 10:37 am, Vic <[email protected]> wrote: > > >>>>>>>>>>> Hi, > > > >>>>>>>>>>> Is it correct that (MooTools 1.2.4/1.2.5) cannot succesfully > > >>>>>>>>>>> select > > >>>>>>>>>>> elements using css selectors by matching on custom data-* > > >>>>>>>>>>> attributes? > > >>>>>>>>>>> If I use the 'rel' or 'class' attribute the correct element gets > > >>>>>>>>>>> selected, but I would like to be able to use the data-* > > >>>>>>>>>>> attributes > > > >>>>>>>>>>> View the example here: http://jsfiddle.net/AWfeD/ > > > >>>>>>>>>>> any ideas? thank you
