fixed and sent a pull request - https://github.com/LearnBoost/engine.io/pull/236
On 21 March 2014 10:37, Dimitar Christoff <[email protected]> wrote: > sorry that's socket.js not server. on mobile now. :) > > > On Friday, March 21, 2014, Dimitar Christoff <[email protected]> wrote: >> >> found their error. server.js line 263 for var in without hasOwnProperty >> check. >> >> change to `if (seqFn.hasOwnProperty(i) && 'function' == typeof seqFn[i]) >> {` and it works fine >> >> On Friday, March 21, 2014, Dimitar Christoff <[email protected]> wrote: >>> >>> hrm - not sure. looks like a mootools extend is causing an issue in >>> the way it's being used when Array.each is coming on.. >>> >>> it's trying to implement the sparse [ undefined ] being passed in here >>> forEach function Array() { [native code] } [ undefined ] >>> >>> >>> /Users/coda/temp/moo.io/node_modules/mootools/lib/mootools-core-1.4.5-server.js:222 >>> return method.apply(item, slice.call(arguments, 1)); >>> ^ >>> TypeError: #<XHR> is not a function >>> at Array.forEach (native) >>> at Function.implement [as forEach] >>> >>> (/Users/coda/temp/moo.io/node_modules/mootools/lib/mootools-core-1.4.5-server.js:222:17) >>> at Array.implement.each >>> >>> (/Users/coda/temp/moo.io/node_modules/mootools/lib/mootools-core-1.4.5-server.js:339:9) >>> at XHR.Socket.setupSendCallback >>> >>> (/Users/coda/temp/moo.io/node_modules/socket.io/node_modules/engine.io/lib/socket.js:264:21) >>> at XHR.EventEmitter.emit (events.js:126:20) >>> at XHR.Polling.onPollRequest >>> >>> (/Users/coda/temp/moo.io/node_modules/socket.io/node_modules/engine.io/lib/transports/polling.js:97:8) >>> at XHR.Polling.onRequest >>> >>> (/Users/coda/temp/moo.io/node_modules/socket.io/node_modules/engine.io/lib/transports/polling.js:53:10) >>> at XHR.onRequest >>> >>> (/Users/coda/temp/moo.io/node_modules/socket.io/node_modules/engine.io/lib/transports/polling-xhr.js:47:33) >>> at Server.handshake >>> >>> (/Users/coda/temp/moo.io/node_modules/socket.io/node_modules/engine.io/lib/server.js:232:13) >>> at Server.handleRequest >>> >>> (/Users/coda/temp/moo.io/node_modules/socket.io/node_modules/engine.io/lib/server.js:176:10) >>> >>> Process finished with exit code 1 >>> >>> As an experiment, I replaced the mootools code with primish and it >>> works fine... (`npm i primish` first) >>> https://gist.github.com/anonymous/9d8140fbf69efc468638 >>> >>> So he XHR object somewhere messes up - I may have time to look at it >>> later but it does not sound like a mootools issue, probably it's >>> passing through non-enumerables or something silly. >>> >>> On 21 March 2014 04:59, utan <[email protected]> wrote: >>> > Sure, no problem.. hope he figure what the problem is.. >>> > >>> > If not then just let me know how to pass u credentials. >>> > >>> > -- >>> > >>> > --- >>> > You received this message because you are subscribed to the Google >>> > Groups "MooTools Users" group. >>> > To unsubscribe from this group and stop receiving emails from it, send >>> > an email to [email protected]. >>> > For more options, visit https://groups.google.com/d/optout. >>> >>> >>> >>> -- >>> Dimitar Christoff >>> >>> "JavaScript is to JAVA what hamster is to ham" >>> @D_mitar - https://github.com/DimitarChristoff >> >> >> >> -- >> Dimitar Christoff >> >> "JavaScript is to JAVA what hamster is to ham" >> @D_mitar - https://github.com/DimitarChristoff > > > > -- > Dimitar Christoff > > "JavaScript is to JAVA what hamster is to ham" > @D_mitar - https://github.com/DimitarChristoff -- Dimitar Christoff "JavaScript is to JAVA what hamster is to ham" @D_mitar - https://github.com/DimitarChristoff -- --- You received this message because you are subscribed to the Google Groups "MooTools Users" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
