My guess is that [EMAIL PROTECTED] (to whom it was assigned) forgot it 
(or maybe he is on vacation or something, haven't checked). But he can't 
check it in yet, the patch still needs a super-review (all patches need 
review AND a super-review).

You should write a message to n.p.m.reviewers and Cc: the person who is 
super reviewing this area (I think [EMAIL PROTECTED] or 
[EMAIL PROTECTED] would do, see 
http://www.mozilla.org/hacking/reviewers.html).

After that, if mscott still is not responding you could ask someone on 
IRC (for example) to check the fix in.

I don't think anybody has done this on purpose, sometimes things just go 
unnoticed for one reason or another. But you did a great job, now let's 
just finish the work...

Len wrote:

> 
> I think someone at mozilla.org really needs to think about how important 
> it is to them to get external contributions to Mozilla. I've been using 
> Mozilla nightlies for ages, and a while ago switched to compiling my own 
> builds, with the intention of contributing by fixing the occasional bug. 
> I saw a bug that scratched my itch and submitted a patch 
> (http://bugzilla.mozilla.org/show_bug.cgi?id=49164). That was over two 
> months ago, and the patch hasn't been checked in, in spite of being 
> reviewed as OK. I've seen mentions of plenty of other bugs in this same 
> situation (there are over 1100 bugs flagged with the patch keyword, but 
> not all of those are "stale"). What kind of message is this is sending 
> to potential contributors?

-- 
   Heikki Toivonen


Reply via email to