Mitchell Baker wrote:
>
> Got questions about the "super-review" process - what it's for, how it
> works, what to expect? You may find answers in this new Code Review
> FAQ. It's not yet linked to from other docs, but it will be shortly.
That FAQ is great!
I have a specific question that's vaguely related to this.
I reported a bug and shortly afterwards provided a patch for it; I also
went on irc to request r= on the patch.
Some standards-compliance issues were raised with the behavior proposed
in the bug, and it was eventually more-or-less agreed that the patch is
right but mozilla's current behavior (unmodified by my patch) is
technically wrong on a closely-related issue (it's "strict
standards-compliance on a useless feature that nobody uses and no
browser supports" vs "backwards compatibility with everyone all the way
back to 3.x generation browsers, and an actually useful behavior".) and
the bug was assigned to the person who would be in the best position to
judge which behavior is appropriate. I have r= conditionally on the
approval of this person. The patch is the *deletion* of approx. 13 lines
and the reviewer agrees that the patch is doing what it intends to do -
the only remaining question is whether the patch is doing the best
thing, which so far nobody has actually disagreed with (they've just
said that the new bug owner is the one with the authority to make a
final decision).
My question is: is there anything that I can or should do to facilitate
the incorporation of this patch? Is mailing the new bug owner to ask for
a quick answer inappropriate? (as of now, the bug is still NEW with no
comments from its new owner).
The bug remains targetted at mozilla1.0 based on my initial nomination
when I submitted the bug, before writing the patch, but it seems to me
that having a patch that's reviewed and all but ready to go can get in
sooner than that. I've changed my nomination to 0.9.2... but will
anybody notice the nomination when the target milestone is already set?
It's a tiny bug and I don't care about it as much as the length of this
email would indicate... but it is my first patch ever and I'm also
trying to get a feel for the mozilla process in the hopes of providing
more patches in the future.
So - any suggestions?
Stuart.
PS I deliberately left out any specific information from the body of the
message because all the questions apply in general and I'd rather get
general answers that I can apply to other bugs later. But for reference,
the bug is http://bugzilla.mozilla.org/show_bug.cgi?id=78206 and all the
people referred to in this mail are obvious from looking at the bug.
