Gervase Markham wrote:
> 
> Don't bother marking bugs with the "mostfreq" keyword any more -
> http://bugzilla.mozilla.org/duplicates.cgi does the magic without needing
> this.

A couple of questions...

1) Does this correctly account for dups of dups? eg
     Bug A has 20 dups
     Bug A is marked dup of Bug B (which previously had none)
   IMHO, the correct behavior would be for Bug B to appear on the
   list, with 21 dups. Is this what happens?

2) Couldn't this be accomplished more cleanly by adding a num_dups field
to the bug itself? Then the only code changes necessary would be to set
bug_b.num_dups += bug_a.num_dups + 1; whenever bug_a is marked dup of
bug_b (with a little extra complexity if bug_b is already marked dup of
something else). That would provide this functionality and also make it
possible to add minimum/maximum num_dups to the query page, providing
the abilities that other people in this thread have been asking for (and
also making duplicates.cgi VERY easy to implement...)

Stuart.

-- 
Stuart Ballard
Programmer
NetReach, Inc.: Single-Source Provider of Internet Solutions
One eCommerce Plaza
124 South Maple Street
Ambler, PA 19002
215.283-2300, x126
www.netreach.net
[EMAIL PROTECTED]

Reply via email to