[MP3 ENCODER] bug in count1_count

[Leonid A. Kulakov]

Hi,


There is a bug in count1_bitcount calculation.
It came from dist10 and still remains in lame.

In functions L3_huffman_coder_count1() (l3bitstream.c, line 799, 3.27beta)
and count1_bitcount() (loop.c, line 2184, ...)

line 
  p = v + (w << 1) + (x << 2) + (y << 3);
must be
  p = (v << 3) + (w << 2) + (x << 1) + y;
  

BTW, in count1_bitcount() lines
        signbits = 0;
        if ( v != 0 )
            signbits ++;
        if ( w != 0 )
            signbits ++;
        if ( x != 0 )
            signbits ++;
        if ( y != 0 )
            signbits ++;
can be simplified by
        signbits = v + w + x + y;
because they can be either 0 or 1.


Regards,
-Leonid


--
MP3 ENCODER mailing list ( http://geek.rcc.se/mp3encoder/ )