>> The new PI2 #defines in util.h (cvs) should be encapsulated by
>> #ifndef PI2 ... #endif. With linux I get warnings
>I removed that stuff from CVS.  Someone with good intentions had
>checked in some global #defines for PI2, PI4, PI12, PI64 etc..

That was me. ;)

>The problem is that this only effects routines written by me and
>Takehiro.  I know in the routine I wrote, I prefer PI/2 to PI2 for
>several reasons which I dont want to be required to explain.  
>Thus to avoid debates on cosmetic coding style, please do not
>check in cosmetic changes unless you wrote the routine
>being changed.

Ok, I just thought it might improve the loops a little with predefined
calcs instead of defining stuff like "#define PI64 (PI/64)". :P

I'll be more careful in the future... ;)


- CISC

--
MP3 ENCODER mailing list ( http://geek.rcc.se/mp3encoder/ )

Reply via email to