Mark Taylor wrote:
> I just took a look at this code, and it looks like
> "noise_shaping_stop" is never used.
>
> Robert modifed outer_loop so that:
>
> with -X0: it will stop the iteration as soon as it
> gets a value of over= 0 (all noise < allowed noise)
>
> with other -X options, it will stop with over=0 if
> it has done at least 7 iterations.
>
> I would like to determine if the extra computations give
> any benifit (and then make that the default with -h)
> but I haven't had the time.
I would recommend the following:
- for quality >= 3, always stop iteration, if over == 0
- at quality == 2 (-h), stop after the 7th iteration, if over == 0
- if quality <= 1, do a full search (yes, it is slower, but CBR
is still realtime even on my 400 MHz CPU)
--
MP3 ENCODER mailing list ( http://geek.rcc.se/mp3encoder/ )
