Hee hee, howdy Roy!
Yah, discovered the bug while I was batch-processing some tracks i'd ripped
for a friend. It was late. :)
Basically, I ripped them, got distracted, then ended up just moving the raw
wav files over into my mp3 directory. They played fine on mine, but didn't
work on his Windows box. He saw that there was no .mp3 on the end of the
filenames, so he went through and renamed all of them %s.mp3 in order to use
them. I came across them later, knowing they were actually unencoded raw wav
files, and set about getting lame to encode them. Thats where I found the
bug...Rather than look at the actual structure of the file, it immediately
decided from the filename that they were MP3s and tried to downsample them.
:)
I can't understand why this concept seems lost on everyone... its a golden
rule of programming. You simply DONT pay attention to the friggin suffix
unless it's _the only way_ to resolve a datatype....which in this case, it
clearly isn't. There are a multitude of ways in which you can differentiate
between formats, even malformed streams.. Hell, its even possible to
determine what encoder was originally used on an MP3 without resorting to
ID3 tags.
Cheers,
Bowie
----- Original Message -----
From: "Roy Rio" <[EMAIL PROTECTED]>
To: <[EMAIL PROTECTED]>
Sent: Monday, November 25, 2002 3:42 PM
Subject: Re: [MP3 ENCODER] Re: Bug in lame 3.93.
> > I don't think laughing at the fact that LAME identifies source files by
> > their suffixes is out of line -- Like I said, in the real world, doing
> such
> > a thing would cause most professional coders to write you off
completely.
> > You can dance around it, and try and justify it however you like....it
> still
> > smacks of amateurism, and you'de be wise to drop that practice in order
to
> > be taken seriously as a coder.
> > Yes, It's that bad.
>
> Remind why we need to fix this for you ... did you accidentally rename the
> file while someone was watching? Did she run out laughing?
>
> "Problem exists between keyboard and chair" describes your problem quite
> well, I think.
>
> > the stick out of your buttfile and #include <humor.h>. Jesus Christ...
Is
> > this all you do all day?
>
> Don't use the Lord's name in vain! Jesus H. Christ! It's just not funny!
>
> > And then, you can move the bong away from your face long enough to read
> > where I told him how to do it with ease.
>
> Sorry, I overlooked that. But somehow I suspect checking if the filename
> ends with ".mp3" is way easier...
>
> Harald
>
> _______________________________________________
> mp3encoder mailing list
> [EMAIL PROTECTED]
> http://minnie.tuhs.org/mailman/listinfo/mp3encoder
_______________________________________________
mp3encoder mailing list
[EMAIL PROTECTED]
http://minnie.tuhs.org/mailman/listinfo/mp3encoder
