On Thu, 29 Jan 2004 13:43:27 +0100 "Michelangelo Nottoli" <[EMAIL PROTECTED]> wrote:
> (question 1) > > can anyone suggest the correct #ifdefs for fopen/fopen64 calls? something > like... > > #if defined(__unix__) || defined(__sun__) > ...call fopen64 > #else > ..call fopen > #endif > > sounds correct ? The should be a configure test for fopen64. If the function is available it can get used. Checking for __unix__ is completely wrong, as there's no guarantee it is available. FreeBSD doesn't has fopen64, the fopen function already provides the necessary functionality. I suggest to use the defines FOPEN and _LARGEFILE_SOURCE (I was told this define needs to be present if you compile with such 64 bit functions): ---snip--- #if defined(_LARGEFILE_SOURCE) # define FOPEN fopen64 #else # define FOPEN fopen #endif ---snip--- Now modify every call to be FOPEN(...) instead if fopen(...). > (question 2) > is there any chance to see this modification on the lame distribution/tar ? Yes, check out the current CVS version and provide a diff (cvs diff) of your modifications. Add the diff to the patch submission section (http://sourceforge.net/tracker/?group_id=290&atid=300290) and send a note to the lame development list (see the CC of this mail). > (question 3) > > do you think there is need to open the output stream also with fopen64 ? I think it would be better. Bye, Alexander. -- I will be available to get hired in April 2004. http://www.Leidinger.net Alexander @ Leidinger.net GPG fingerprint = C518 BC70 E67F 143F BE91 3365 79E2 9C60 B006 3FE7 _______________________________________________ mp3encoder mailing list [EMAIL PROTECTED] http://minnie.tuhs.org/mailman/listinfo/mp3encoder
