On 5/19/2013 9:22 AM, Marc Sabatella wrote: > My hope is that this will actually turn out to be little more than adding a > function to convert my ParsedChord to an HChord on the export side, and > parsing the name that an HChord can already generate on the import side. > But I'm prepared to have to dig in deeper. I'm trying to follow the flow of what is happening in the code, and I do a question for anyone who has worked on MusicXML & chord symbols:
HDegree::text() appears to be a no-op. It does part of the calculation it is supposed to do, then always returns an empty string, with the relevant code to finish the calculation and return the calculated value commented out. It is commented out all the way back to the first checkin I could find on GitHub, but it's active in the 1.3 source on SourceForge. So I can't even find the relevant logs for the commit that did the commenting out. The ramification of the change appears to be that fromXml(kind,degreeList) seems destined to fail any time there is a degree list at all, so we rely more on "Strategy II" using Harmony::resolveDegreeList() to help us match chords on import. That's fine, but this is right where I'd need to hook in to catch unrecognized chords, and I'd like to understand more about why this change might have been made before messing with anything here. I guess that's not exactly a question. The question is, what do I need to know about any of this? Marc ------------------------------------------------------------------------------ AlienVault Unified Security Management (USM) platform delivers complete security visibility with the essential security capabilities. Easily and efficiently configure, manage, and operate all of your security controls from a single console and one unified framework. Download a free trial. http://p.sf.net/sfu/alienvault_d2d _______________________________________________ Mscore-developer mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/mscore-developer
