On May 20, 2013, at 6:00 AM, Leon Vinken <[email protected]> wrote:
> "anyone who has worked on MusicXML & chord symbols" would probably be > lasconic, Werner and me. As far as I am concerned, if you need help, just > let me know. I you feel like modifying the MusicXML importer/exporter > yourself, I am willing to help or to review. If you'd like me to integrate > your chord symbol changes into the MusicXML code, I can do that too. Well, I wouldn't mind understanding this part of the code better, so I'll take a crack at it. Hopefully it won't take me any longer to come up to speed on the existing code than it would take you to do the same for my new code. Thanks for the offer to help, and I'm sure I'll have more questions. I'm pretty good about figuring how existing code works, but it's when I see remnants of older abandoned code that also may or may not have worked that I wonder what might be going on. > About your "HDegree::text()", I don't know. I simply cannot remember who did > the last updates and why. I'll have to check MuseScores current behavior wrt > to MusicXML chords and verify it still works OK. It does as far as I can tell. Which is to say, it still correctly handles the cases on import where a chord is recognized from the chord list. It's just that it appears it probably used to recognize more chords on the first call to fromXml - where the degree list was passed in as a parameter - whereas now, chords with degree lists will generally fail that first test and fall through to the second test, matching on kind only and then using resolveDegreeList. That method succeeds in the cases I've tried, so it still works. A sort of similar situation - well, slightly similar, anyhow - on export. The last 20 or so lines of exportxml.cpp are disabled via #if 0. Looks like this is an alternate way of achieving the same thing as the code directly above it - outputting the XML tags for Harmony objects. And before I get in there and add yet another way of outputting tags, I'd like to understanding why there are two methods already, whether one was abandoned in favor of the second, and why if so. Marc ------------------------------------------------------------------------------ AlienVault Unified Security Management (USM) platform delivers complete security visibility with the essential security capabilities. Easily and efficiently configure, manage, and operate all of your security controls from a single console and one unified framework. Download a free trial. http://p.sf.net/sfu/alienvault_d2d _______________________________________________ Mscore-developer mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/mscore-developer
