On 8/14/2014 1:13 PM, Alexey Pavlov wrote: > > 14 авг. 2014 г., в 21:04, Richard Shaw <[email protected]> написал(а): > >> I found the issue... No idea what it's not a problem on other platforms. >> >> >> diff -Naur cmake-3.0.1.orig/Modules/FindwxWidgets.cmake >> cmake-3.0.1.wxfix/Modules/FindwxWidgets.cmake >> --- cmake-3.0.1.orig/Modules/FindwxWidgets.cmake 2014-07-31 >> 10:03:56.000000000 -0500 >> +++ cmake-3.0.1.wxfix/Modules/FindwxWidgets.cmake 2014-08-14 >> 12:02:11.604331400 -0500 >> @@ -792,6 +792,10 @@ >> wxWidgets_CXX_FLAGS "${wxWidgets_CXX_FLAGS}") >> string(REPLACE "-I" "" >> wxWidgets_INCLUDE_DIRS "${wxWidgets_INCLUDE_DIRS}") >> + >> + # Flags are a string, not a list, fix it here >> + string(REPLACE ";" " " >> + wxWidgets_CXX_FLAGS "${wxWidgets_CXX_FLAGS}") >> >> DBG_MSG_V("wxWidgets_DEFINITIONS=${wxWidgets_DEFINITIONS}") >> DBG_MSG_V("wxWidgets_INCLUDE_DIRS=${wxWidgets_INCLUDE_DIRS}") >> >> Thanks, >> Richard > > Thanks, will rebuild cmake with this patch soon. > > Regards, > Alexey.
If this is part of the CMake source, shouldn't this patch be pushed upstream so that it can be fixed on all platforms assuming the CMake developers will accept it? At least they can be made aware of the issue. I know it's convenient to fix it here and in the short term that's fine. These kinds of patches have a way of spiraling out of control. If you don't believe me, look at the mess required to build KiCad (I'm one of the lead developers) with all of the dependency library patching we have to do. It can quickly become a maintenance nightmare. Thanks, Wayne ------------------------------------------------------------------------------ _______________________________________________ Msys2-users mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/msys2-users
