Richard, Richard Shaw <[email protected]> writes:
>> Alexey, can we wait a week or two for a response from the CMake >> wxWidgets module maintainer before incorporating the patch? > > > I've got it fixed locally for myself so I don't really care but why wait > that long? The patch is fairly straight forward. The only thing it does is > replace any occurrence of ";" with a space in whatever wasn't removed to be > part of the definitions or includes macros. > > Unless there's a valid reason for a semicolon to be in a compiler flag, the > patch is at worst useless and it fixes a known issue. > > If upstream decides to fix it in a different way as long as it works then > we just drop this patch. The bug is about an specific CMake module when used with certain input and the zone touched by the patch is several years old, so we can assume that the problem is far from being a common one. There is no reason for hurry. OTOH when you apply a patch you are forking the project. This has severe consequences for the community (and creates extra work for the maintainers.) Right now MSYS2 CMake has a single, simple patch which is related to MSYS2 itself, while your patch addresses a CMake bug which is not MSYS2-specific. The moment Alexey applies it, he is taking the role of CMake maintainer. Multiply this by the hundreds of packages MSYS2 has... IMHO MSYS2 should limit itself to patches required by the specific needs of this environment (and perhaps some MinGW-w64 patches.) Broadening the scope is a recipe for maintainer burn-out. ------------------------------------------------------------------------------ _______________________________________________ Msys2-users mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/msys2-users
