Steffen Prohaska schrieb: > > On Apr 14, 2008, at 8:32 AM, Johannes Sixt wrote: > >> >> Steffen Prohaska schrieb: >>> I tweaked the tests for msysgit, such that they either pass or are >>> disabled. My commits are on branch work/tests (90fba70984) in >>> 4msysgit. The branch is based on mingw/master. So you can pull them if >>> you like. >> >> Thanks a lot! You introduce is_mingw, but use it only in a few places. >> Would you mind converting all cases (in this series) to use is_mingw? > > Hmm... maybe. I added is_mingw only where it should eventually be > removed, after the tests are fixed. The other commits contain switch > statements that may stay there for a longer time.
Eventually, all of those tests should pass. So while some of the conditionals may stay longer than others, none of them should remain indefinitely. Moreover, 'test "$is_mingw"' is much more readable and it saves a fork(). -- Hannes
