On Apr 15, 2008, at 12:30 AM, Steffen Prohaska wrote:


On Apr 14, 2008, at 8:32 AM, Johannes Sixt wrote:


Steffen Prohaska schrieb:
I tweaked the tests for msysgit, such that they either pass or are
disabled.  My commits are on branch work/tests (90fba70984) in
4msysgit. The branch is based on mingw/master. So you can pull them if
you like.

Thanks a lot! You introduce is_mingw, but use it only in a few places.
Would you mind converting all cases (in this series) to use is_mingw?

Hmm... maybe. I added is_mingw only where it should eventually be removed, after the tests are fixed. The other commits contain switch statements that may stay there for a longer time.

I improved the patch series.  Tests as no longer skipped but instead
marked broken.  You can pull it from work/tests in 4msysgit.  I decided
against is_mingw and instead replaced it with "case $(uname) ... MINGW".
The series consists of the following commits:

f3ffa502 t7201: Mark tests as broken on MinGW
b74e70b3 t5505: On MinGW, use Windows path in expected output of "git remote show"
ab8a9f21 t7401: Tell diff to ignore whitespace on MinGW
fe3238dc t3903: Mark tests as broken on MinGW
f94ce3a5 t5503: Mark tests as broken on MinGW
ed697a24 t5511: Mark test with "::" as broken on MinGW

        Steffen

Reply via email to