Hi, On Wed, 2 Jul 2008, Steffen Prohaska wrote:
> On Jul 2, 2008, at 6:15 PM, Johannes Schindelin wrote: > > >On Wed, 2 Jul 2008, Junio C Hamano wrote: > > > > >Steffen Prohaska <[EMAIL PROTECTED]> writes: > > > > > > >Signed-off-by: Johannes Schindelin <[EMAIL PROTECTED]> > > > >Signed-off-by: Steffen Prohaska <[EMAIL PROTECTED]> > > > > > >No commit log message? Justification? > > > >Justification: adding absolute paths was not caught properly on > >Windows, and this was the easiest patch. > > > >However, IIRC, in the meantime we are nice to the user, and allow > >absolute paths (which we turn into a relative path, or error out if it > >is not under the current working directory). > > > >Steffen, can you revert the patch and verify that my memory does not > >fail me? > > Is > > git add /c/msysgit/git/read-cache.c > > an appropriate test? > > It fails with > > error: 'c:/msysgit/git/read-cache.c' is outside repository > > no matter if the commit is reverted or not. Yes, that is enough. It proves that the patch 11/12 is unnecessary and should be removed from 4msysgit.git. Thanks, Dscho
