On Tue, Jul 8, 2008 at 8:02 PM, Johannes Schindelin wrote: > > On Tue, 8 Jul 2008, Peter Harris wrote: > >> /* >> + * ANSI emulation wrappers >> + */ >> + >> +int git_fputs(const char *str, FILE *stream); >> +int git_printf(const char *format, ...) __attribute__((format (printf, 1, >> 2))); >> +int git_fprintf(FILE *stream, const char *format, ...) >> __attribute__((format (printf, 2, 3))); > > Should these not rather be "mingw_*", or even better, "winansi_*"?
Yes, they should. >> +/* >> + ANSI codes to implement: m, K >> +*/ > > Does this mean that 'm' and 'K' are TODOs? (From your patch, it seems > that 'm' is done already.) > > Anyway, if something is left to do, that should at least be described. If > it is not left to do, it should be described, too... That was intended to mean "ANSI codes that git appears to use: m, K". You are correct, that comment is terrible. I'll expand it and re-send the patch tomorrow. > Other than that, looks quite good to me! Thanks for the review. Peter Harris
