On Mittwoch, 2. Juli 2008, Steffen Prohaska wrote:
> The implementation directly calls the Win32 API to launch the browser.
> Note that the specific directory layout of msysgit is required.

> +#ifdef __MINGW32__
> +     const char* exec_path = git_exec_path();
> +     char *htmlpath = make_native_separator(
> +                        mkpath("%s/../doc/git/html/%s.html"
> +                               , exec_path
> +                               , git_cmd)
> +                      );
> +     if (!file_exists(htmlpath)) {
> +             htmlpath = make_native_separator(
> +                           mkpath("%s/../doc/git/html/git-%s.html"
> +                                  , exec_path
> +                                  , git_cmd)
> +                        );
> +             if (!file_exists(htmlpath)) {
> +                     fprintf(stderr, "Can't find HTML help for '%s'.\n"
> +                             , git_cmd);
> +                     exit(1);
> +             }
> +     }
> +     printf("Launching default browser to display HTML help ...\n");
> +     ShellExecute(NULL, "open", htmlpath, NULL, "\\", 0);
> +#else

Can't we move this part into git-web--browse.sh? It should be a matter of 
calling

        start $htmlpath

(and msys-1.0.dll would convert slashes to backslashes for us).

-- Hannes

Reply via email to